enable bm_estimate_time to accept bm_max_secs #2354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67150918 |
|
This pull request was exported from Phabricator. Differential Revision: D67150918 |
Summary: Currently, if we enable `bm_estimate_time`, the max benchmark time is 5 seconds. We should allow users to increase it by tuning bm_max_secs Reviewed By: Gownta Differential Revision: D67150918
ZhijianJiang
force-pushed
the
export-D67150918
branch
from
0ac2ac0 to
38b00be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67150918 |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Dec 14, 2024
Summary: X-link: facebook/folly#2354 Currently, if we enable `bm_estimate_time`, the max benchmark time is 5 seconds. We should allow users to increase it by tuning bm_max_secs Reviewed By: Gownta Differential Revision: D67150918 fbshipit-source-id: 4f23e83d39b11581bff4e5c1c67d2b2e159acbef
|
This pull request has been merged in 889f0ad. |
|
This pull request has been reverted by d6c2c77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, if we enable
bm_estimate_time, the max benchmark time is 5 seconds. We should allow users to increase it by tuning bm_max_secsDifferential Revision: D67150918